Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove override style for pinned column's text #2756

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Remove override style for pinned column's text #2756

merged 4 commits into from
Nov 21, 2023

Conversation

alycrys
Copy link
Contributor

@alycrys alycrys commented Nov 20, 2023

closes #2755

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 0607a7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/ag-grid-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 0:44am

@alycrys alycrys changed the title Remove override style for pinned column's border Remove override style for pinned column's text Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Storybook Preview Link https://edf69ec0.saltdesignsystem-storybook.pages.dev

joshwooding
joshwooding requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

@alycrys alycrys requested a review from joshwooding November 21, 2023 10:46
@joshwooding joshwooding force-pushed the ag-grid-pinned-text-overlaps branch from fca6feb to 0607a7b Compare November 21, 2023 12:35
@alycrys alycrys merged commit 8650840 into main Nov 21, 2023
@alycrys alycrys deleted the ag-grid-pinned-text-overlaps branch November 21, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@Fercas123 Fercas123 Fercas123 approved these changes

@ImmanuelBaskaran ImmanuelBaskaran ImmanuelBaskaran left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove override style for pinned column's text
4 participants
@alycrys @joshwooding @Fercas123 @ImmanuelBaskaran