Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Header Pattern Site Page #2757

Merged
merged 19 commits into from
Nov 28, 2023
Merged

App Header Pattern Site Page #2757

merged 19 commits into from
Nov 28, 2023

Conversation

lilyvc
Copy link
Contributor

@lilyvc lilyvc commented Nov 20, 2023

closes #2669

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 253339d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 2:53pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Storybook Preview Link https://ba9c6499.saltdesignsystem-storybook.pages.dev

@lilyvc lilyvc marked this pull request as ready for review November 23, 2023 11:40
@joshwooding joshwooding requested a review from a team November 23, 2023 13:45
mikearildbrown
mikearildbrown reviewed Nov 23, 2023
View reviewed changes
site/docs/patterns/app-header.mdx Outdated Show resolved Hide resolved
site/docs/patterns/app-header.mdx Outdated Show resolved Hide resolved
site/docs/patterns/app-header.mdx Show resolved Hide resolved
site/docs/patterns/app-header.mdx Show resolved Hide resolved
site/docs/patterns/app-header.mdx Outdated Show resolved Hide resolved
site/docs/patterns/app-header.mdx Outdated Show resolved Hide resolved
site/docs/patterns/app-header.mdx Outdated Show resolved Hide resolved
site/docs/patterns/app-header.mdx Outdated Show resolved Hide resolved
site/docs/patterns/app-header.mdx Outdated Show resolved Hide resolved
@joshwooding joshwooding force-pushed the app-header-pattern-page branch from 8ca5296 to 253339d Compare November 28, 2023 14:48
@joshwooding joshwooding merged commit 563c758 into main Nov 28, 2023
@joshwooding joshwooding deleted the app-header-pattern-page branch November 28, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feliciackh feliciackh feliciackh left review comments

@joshwooding joshwooding joshwooding approved these changes

@mikearildbrown mikearildbrown mikearildbrown approved these changes

@ivan-calderon ivan-calderon ivan-calderon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Header Pattern publish to site and examples
5 participants
@lilyvc @joshwooding @feliciackh @mikearildbrown @ivan-calderon