Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File dropzone docs #2854

Merged
merged 10 commits into from
Dec 19, 2023
Merged

File dropzone docs #2854

merged 10 commits into from
Dec 19, 2023

Conversation

Fercas123
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 476b848

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 3:49pm

@Fercas123 Fercas123 changed the base branch from main to filedropzone December 18, 2023 11:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2023 •
edited
Loading

Storybook Preview Link https://39f65af4.saltdesignsystem-storybook.pages.dev

joshwooding
joshwooding previously requested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to be updated to match the new content guidelines, could you take a look at #2787

You can see how the other docs have been updated too

mikearildbrown
mikearildbrown reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@mikearildbrown mikearildbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have also sent for proofreading

site/docs/components/file-drop-zone/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/usage.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/usage.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/usage.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/usage.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/file-drop-zone/examples.mdx Outdated Show resolved Hide resolved
Fercas123 and others added 2 commits December 18, 2023 18:43
@ivan-calderon
Update Error.tsx
06a7427 
I just updated the error text in the example to "File format is not allowed" to align to our recommendation of: "Error messages should provide feedback to guide the user resolve the issue."
@Fercas123 Fercas123 merged commit 16cd8e1 into filedropzone Dec 19, 2023
11 checks passed
@Fercas123 Fercas123 deleted the file-dropzone-docs branch December 19, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-calderon ivan-calderon ivan-calderon approved these changes

@joshwooding joshwooding Awaiting requested review from joshwooding

@mikearildbrown mikearildbrown Awaiting requested review from mikearildbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fercas123 @joshwooding @mikearildbrown @ivan-calderon