Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay docs and examples on site #2860

Merged
merged 14 commits into from
Jan 22, 2024
Merged

Overlay docs and examples on site #2860

merged 14 commits into from
Jan 22, 2024

Conversation

feliciackh
Copy link
Contributor

@feliciackh feliciackh commented Dec 19, 2023 •
edited
Loading

closes #2807
documentation for #2735

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 29864dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 3:55pm

@feliciackh feliciackh mentioned this pull request Dec 19, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Storybook Preview Link https://772e1467.saltdesignsystem-storybook.pages.dev

@feliciackh feliciackh added the type: documentation Improvements or additions to documentation label Dec 19, 2023
mikearildbrown
mikearildbrown reviewed Dec 19, 2023
View reviewed changes
site/docs/components/overlay/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/usage.mdx Outdated Show resolved Hide resolved
@feliciackh feliciackh mentioned this pull request Dec 20, 2023
Merged
mikearildbrown
mikearildbrown reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@mikearildbrown mikearildbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of bits i noticed, rest looks good!

site/docs/components/overlay/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/examples.mdx Outdated Show resolved Hide resolved
@feliciackh feliciackh force-pushed the overlay branch 3 times, most recently from a062849 to f9aac4b Compare January 3, 2024 16:08
@feliciackh feliciackh marked this pull request as draft January 4, 2024 15:25
alycrys
alycrys reviewed Jan 10, 2024
View reviewed changes
site/docs/components/overlay/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/overlay/index.mdx Outdated Show resolved Hide resolved
site/src/examples/overlay/Default.tsx Outdated Show resolved Hide resolved
site/src/examples/overlay/Default.tsx Outdated Show resolved Hide resolved
site/src/examples/overlay/Default.tsx Outdated Show resolved Hide resolved
site/src/examples/overlay/Default.tsx Outdated Show resolved Hide resolved
site/src/examples/overlay/Default.tsx Outdated Show resolved Hide resolved
@feliciackh feliciackh marked this pull request as ready for review January 11, 2024 15:18
@joshwooding joshwooding merged commit 343ae60 into overlay Jan 22, 2024
14 of 15 checks passed
@joshwooding joshwooding deleted the overlay-docs branch January 22, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alycrys alycrys alycrys left review comments

@mikearildbrown mikearildbrown mikearildbrown left review comments

@lukeac123 lukeac123 lukeac123 approved these changes

Assignees
No one assigned
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@feliciackh @alycrys @lukeac123 @mikearildbrown @joshwooding