-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable theme next options for site component examples #3897
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@bhoppers2008 @pseys @dplsek a few outstanding questions to be figured out. let me know your thoughts |
81686b6
to
92ddceb
Compare
92ddceb
to
314fee5
Compare
697d8f5
to
ed94108
Compare
This reverts commit b93cd82.
ed94108
to
ce0b6b5
Compare
Replaced by #4082 |
Adds a few theme next controls to component examples, just like mode and density
There should be some priorities for the new styling options (accent/corner/headingFont/actionFont) for the user to try out. My first thought is two font options is not high priority (also we don't have font file available on the site anyway)
Preview link : https://saltdesignsystem-git-3738-theme-next-site-examples-fed-team.vercel.app/salt/components/button/examples
Should these options be persisted? should we use url param? Change between component pages should keep the setting? Enable URL share?To be done in a separate issue, need to think how to best integrate with Mosaic store, and/or zustand persistBlocked by jpmorganchase/mosaic#640
Does not include
TableOfContents
implementation inDetailComponent
, so scroll can count in additional height#3738