Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable theme next options for site component examples #3897

Closed
wants to merge 12 commits into from

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Jul 25, 2024

Adds a few theme next controls to component examples, just like mode and density

There should be some priorities for the new styling options (accent/corner/headingFont/actionFont) for the user to try out. My first thought is two font options is not high priority (also we don't have font file available on the site anyway)

Preview link : https://saltdesignsystem-git-3738-theme-next-site-examples-fed-team.vercel.app/salt/components/button/examples

  • Decide which styling options toggle to show on the site. (Does not include font, pending Amplitude license)
  • Decide which control to use, switch / toggle button / anything else? (Design done by Honey)
  • Work on page responsiveness (reflows correctly)
  • Should these options be persisted? should we use url param? Change between component pages should keep the setting? Enable URL share? To be done in a separate issue, need to think how to best integrate with Mosaic store, and/or zustand persist
  • Should theme next toggles has additional label, to make it clear? (Added tooltip)

Blocked by jpmorganchase/mosaic#640

Does not include

#3738

Copy link

changeset-bot bot commented Jul 25, 2024

⚠️ No Changeset found

Latest commit: dde10d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 5:14pm

@origami-z
Copy link
Contributor Author

@bhoppers2008 @pseys @dplsek a few outstanding questions to be figured out. let me know your thoughts

@origami-z
Copy link
Contributor Author

Replaced by #4082

@origami-z origami-z closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant