Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListBox not scrolling to the active item in some circumstances #3900

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

joshwooding
Copy link
Contributor

@joshwooding joshwooding commented Jul 26, 2024

Copy link

changeset-bot bot commented Jul 26, 2024

🦋 Changeset detected

Latest commit: be36b76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 10:37am

@joshwooding
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @joshwooding! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 26, 2024
@joshwooding joshwooding marked this pull request as ready for review July 26, 2024 10:32
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 26, 2024
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 26, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 26, 2024
@joshwooding joshwooding merged commit 31c3702 into main Jul 26, 2024
16 of 17 checks passed
@joshwooding joshwooding deleted the fix-list-scrolling branch July 26, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Box doesn't scroll item to view when used in Dialog
3 participants