Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render prop to Link #4325

Merged
merged 8 commits into from
Jan 20, 2025

Conversation

liamsms
Copy link
Contributor

@liamsms liamsms commented Oct 20, 2024

Closes #3627

Added render prop to Link using same approach as NavigationItem.

Copy link

changeset-bot bot commented Oct 20, 2024

🦋 Changeset detected

Latest commit: 9fdefbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@salt-ds/core Minor
@salt-ds/countries Patch
@salt-ds/data-grid Patch
@salt-ds/lab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 20, 2024

@liamsms is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@joshwooding
Copy link
Contributor

Thanks for raising this, @liamsms. In the future, please leave a comment on the issue letting us know you'll pick it up, like others in #3627.

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 2:57pm

@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 18, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 18, 2024
@joshwooding joshwooding force-pushed the add-render-prop-to-link branch from 4ac1224 to ae72662 Compare December 19, 2024 00:27
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 19, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 19, 2024
@joshwooding joshwooding force-pushed the add-render-prop-to-link branch from ae72662 to bd7efa8 Compare January 7, 2025 08:11
@joshwooding joshwooding force-pushed the add-render-prop-to-link branch from bd7efa8 to 169b8bf Compare January 8, 2025 07:53
@mark-tate
Copy link
Contributor

/release-pr

Copy link
Contributor

🫰✨ Thanks @mark-tate! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 20, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 20, 2025
@mark-tate mark-tate added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 20, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 20, 2025
@joshwooding joshwooding merged commit 225a61b into jpmorganchase:main Jan 20, 2025
16 checks passed
@liamsms liamsms deleted the add-render-prop-to-link branch January 21, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link component can provide it's own implementation of anchor tag (as per NavigationItem)
3 participants