Flex layout and items margin and paddings #4573
Open
+630
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ad1a87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fercas123
force-pushed
the
layout-margin-padding
branch
from
0e45d92 to
61fa5c3
Compare
|
/release-pr |
Fercas123
force-pushed
the
layout-margin-padding
branch
2 times, most recently
from
f5438d1 to
510c932
Compare
|
i had added examples to all layouts built from flex, then removed them because it seemed too repetitive... there are 3 options i considered but could use some feedback
|
|
needs a changeset |
Fercas123
force-pushed
the
layout-margin-padding
branch
2 times, most recently
from
7de3725 to
bff66ec
Compare
chrispcode
previously approved these changes
Jan 27, 2025
|
this is great :) we also have to add 100% width/height to so many of our layout components... if there was a prop to do this too that would be awesome |
Fercas123
force-pushed
the
layout-margin-padding
branch
from
2275877 to
2ad1a87
Compare
chrispcode
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add margin and paddings to flex layout as a multiplier of salt-spacing