This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Don't send buffers to unknown clients #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever autoadd is not enabled and an unknown client connects to ZNC, ZNC will proceed to indiscriminately send the contents of all buffers to the client. However, this behaviour keeps repeating each time the clients connects again: as this module is expected to be used with AutoClearChanBuffer and AutoClearQueryBuffer both off, the buffers aren't cleared, and ClientBuffer does not prevent ZNC from re-sending the buffers on each client connect. ClientBuffer should instead prevent ZNC from sending buffer contents to unidentified clients. Fixes jpnurmi#17.
|
Closing, since my fork is now the project's main repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17