Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Psst Flatpak #141

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Initial Psst Flatpak #141

wants to merge 4 commits into from

Conversation

TheEvilSkeleton
Copy link

@TheEvilSkeleton TheEvilSkeleton commented Aug 23, 2021 •
edited
Loading

The point of this MR is to test Flatpak packages straight from the master branch.

Related to #16.

@Ozymandias42 Ozymandias42 mentioned this pull request Aug 23, 2021
Closed
@TheEvilSkeleton @Ozymandias42
Initial Psst Flatpak
eedb149 
Co-authored-by: Ozymandias42 <[email protected]>
@TheEvilSkeleton TheEvilSkeleton mentioned this pull request Aug 23, 2021
Closed
@TheEvilSkeleton TheEvilSkeleton marked this pull request as draft August 23, 2021 21:02
@TheEvilSkeleton
Copy link
Author

/cc @jpochyla

jpochyla
jpochyla reviewed Sep 1, 2021
View reviewed changes
.pkg/FLATPAK/com.github.jpochyla.Psst.metainfo.xml

<description>
<p>
Fast Spotify client with native GUI, without Electron, built in Rust. Very early in development, lacking in features, stability, and general user experience. It is being tested only on Mac so far, but aims for full Windows and Linux support. Contributions welcome!
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to the bundle values from Cargo.toml?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly not. Flatpak uses AppStream.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I mean literally copy-pasting the texts from Cargo.toml.

Copy link
Author

@TheEvilSkeleton TheEvilSkeleton Sep 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite unfamiliar with Rust in general (but familiar with Flatpak packaging). When using Cargo.toml, does it create an AppStream file automatically?

@jpochyla
Copy link
Owner

jpochyla commented Sep 1, 2021

Hi, thanks for the PR, and sorry for the wait. Do you think we could move the .deb packaging job to this Packaging workflow?

@TheEvilSkeleton
Copy link
Author

TheEvilSkeleton commented Sep 1, 2021 •
edited
Loading

Hi, thanks for the PR, and sorry for the wait. Do you think we could move the .deb packaging job to this Packaging workflow?

If we change some things in the CI, then yes. Although I haven't really played with GitHub CI other than packaging Flatpak binaries, and I believe it'd be better if this is in a separate MR.

@TheEvilSkeleton
Copy link
Author

@jpochyla can you approve the workflow so it can run the CI? I'd like to know if it's configured correctly.

@TheEvilSkeleton
Copy link
Author

@jpochyla please approve it again 😅.

@TheEvilSkeleton TheEvilSkeleton mentioned this pull request Sep 2, 2021
Open
@jpochyla jpochyla mentioned this pull request Sep 14, 2021
Closed
@jacksongoode
Copy link
Collaborator

@TheEvilSkeleton How far away is this from this getting published on flathub?

@TheEvilSkeleton
Copy link
Author

@jacksongoode depends on how long it takes for this app to get its first release.

@paolobarbolini
Copy link
Contributor

Is .pkg/FLATPAK/cargo-sources.json supposed to be committed to the repo / can the command used to generate it be documented?

@TheEvilSkeleton
Copy link
Author

Yes.

@TheEvilSkeleton
Copy link
Author

TheEvilSkeleton commented Aug 27, 2022 •
edited
Loading

@jpochyla hey, do you still want me to work on this? Perhaps I could contribute for Linux related stuff and create a manifest so you could publish it on Flathub?

@TheEvilSkeleton
Copy link
Author

Closing this since I got no response.

@jacksongoode
Copy link
Collaborator

@Insprill @TheEvilSkeleton It would be worthwhile following up on this now that there are new maintainers. I'm sure we could get this into Flathub if we tried.

@jacksongoode jacksongoode reopened this May 12, 2023
@TheEvilSkeleton
Copy link
Author

Thanks. Do you want me to submit the stable version directly to Flathub?

@jacksongoode
Copy link
Collaborator

Thanks. Do you want me to submit the stable version directly to Flathub?

I suppose we could do that. The existing workflow is a little broken and might need some updating as well. We don't currently have any versioning since this is still very WIP. I'm not sure how Flatpak would handle updates in this way.

@TheEvilSkeleton TheEvilSkeleton mentioned this pull request May 13, 2023
Draft
7 tasks
@TheEvilSkeleton
Copy link
Author

Sure. I opened flathub/flathub#4151 and I'll contribute everything I can as well.

@TheEvilSkeleton TheEvilSkeleton mentioned this pull request May 13, 2023
Open
@jacksongoode jacksongoode mentioned this pull request May 13, 2023
Closed
@SO9010 SO9010 mentioned this pull request Sep 26, 2024
Open
@jacksongoode jacksongoode mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpochyla jpochyla jpochyla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheEvilSkeleton @jpochyla @jacksongoode @paolobarbolini