Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Demos: Add skipping-past-dialog demo #8524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Demos: Add skipping-past-dialog demo #8524

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link

Observations:

  • The dialog hash key doesn't seem to work even with the custom selectmenu anymore. Weird.
  • Hooking into pagebeforechange seems to scroll the page first. In fact, if the page is scrolled down, an ugly jump-to-top is visible before the transition. I know this is a pretty long-standing issue.

Anyhoo, this is an initial pass.

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Sep 28, 2016
@ecadius
Copy link
Contributor

ecadius commented Jan 31, 2019

Who can sign the Contributor License Agreement?

@ecadius ecadius mentioned this pull request Jan 31, 2019
Open
37 tasks
Base automatically changed from master to main March 16, 2021 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@arschmitz arschmitz

Labels
Action: PR needs reviewing Component: Navigation Demos
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrielschulhof @ecadius @arschmitz @jquerybot @JSFOwner