-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hieradata: Prepare for jQuery UI 1.14 #56
Conversation
Everything looks fine on staging: https://stage.api.jqueryui.com/1.13/. In production, though, it seems the other |
Oh, actually, on staging the 1.13 home page is fine but there are no categories on the left side. I wonder if I need to create a new tag on |
The structure appeared after merging this to |
BTW, I'm talking about categories, but all the pages are missing, including entries like https://api.jqueryui.com/1.13/addClass/. FWIW, when I pushed a tag to the Some time has passed since I pushed the tag and production is still empty for 1.13, though... 🤔 |
Puppet has applied the change to the builder.
Looking at the working directory:
Looking at the notifier, note that your added YAML entry for the 1-13 subsite, like the other subsites, simply following the branch in both staging and prod. The branch+tags is currently set on the main site only. We don't currently have extra tags overhead and separation in the new infra, as changes are less frequent there. Tag restriction could be set there, if you like, in the same way. At the moment, the system "should" build on commits instead.
So what events has the notifier processed recently?
@mgol My guess is that the branch hasn't received a commit yet since deploying the puppet change to production. To be sure you could verify the timing at https://github.com/organizations/jquery/settings/hooks. I suggest either using the hooks admin page on GitHub to find the "1-13 branch commit" event under builder-02, and replay it (it would have been ignored before the puppet change to listen for it). Or, push a no-op commit to the branch. |
It'd be great if new sites deployed from the latest commit on the branch or the latest matching tag so that noop commits or tags were not required. I'll push a noop commit later to the EDIT: I pushed a dummy commit (just a new tag) and it worked, indeed. |
No description provided.