Core: Prepare for Migrate 4.0.0 #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2024
mgol
force-pushed
the
4.x-stable-proposal
branch
from
6312a6c
to
121042d
Compare
The `self-closed-tags` patch remains, despite being a breaking change in jQuery 3.5.0, not 4.0.0. There are a few reasons for that: 1. It's an exception that a breaking change arrived in a non-major version bump. Some people may be upgrading from jQuery 3.4.0 or older and it's good to make it work for them. 2. The patch is disabled by default, so the concern of people on newer jQuery 3.x upgrading to jQuery 4.x with Migrate 4.x getting patches restoring behavior from an version older than the pre-upgrade one does not exist. 3. This was a pretty big break, it may help people update if we still support it.
This will save space and avoid potential divergence from Core. Also, simplify the `deferred.pipe` patch.
Also: 1. Group `warnings.md` by this type. 2. Rename `jQuery.migrateWarnings` to `jQuery.migrateMessages`. 3. Rename `jQuery.migrateDeduplicateWarnings` to `jQuery.migrateDeduplicateMessages`. 4. Adding "info" versions of some internal APIs. Fixes jquerygh-472
mgol
force-pushed
the
4.x-stable-proposal
branch
from
121042d
to
7d2ddb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
1. Core: Remove support for jQuery 3.x
2. Core: Remove patches for breaking changes in jQuery 3.0.0 or older
The
self-closed-tagspatch remains, despite being a breaking change in jQuery3.5.0, not 4.0.0. There are a few reasons for that:
Some people may be upgrading from jQuery 3.4.0 or older and it's good to
make it work for them.
3.x upgrading to jQuery 4.x with Migrate 4.x getting patches restoring
behavior from an version older than the pre-upgrade one does not exist.
it.
3. Core: Don't reimplement deprecated but not removed APIs
This will save space and avoid potential divergence from Core.
Also, simplify the
deferred.pipepatch.4. Core: Use
console.infofor deprecations without removals.Also:
warnings.mdby this type.jQuery.migrateWarningstojQuery.migrateMessages.jQuery.migrateDeduplicateWarningstojQuery.migrateDeduplicateMessages.Fixes gh-472