Add more permissions (Fixes #50 & #40) #52
Conversation
Also update old server version in build.gradle and add all permissions to readme.
| @@ -59,6 +59,10 @@ public void onPluginMessageReceived(String channel, Player sender, byte[] payloa | |||
| return; | |||
| } | |||
|
|
|||
| if(!sender.hasPermission("vive.use")) { | |||
There was a problem hiding this comment.
I'm not really okay with this permission. It's meant to be a thing that just works, no conditionals.
There was a problem hiding this comment.
It just works with the default settings unless the vive.use permission is manually revoked by the server administrator. (Which basically makes it behave like he didn't install the plugin in the first place to the player in question but out of the box it just works)
There was a problem hiding this comment.
Yes I know, but I do not understand the purpose of that, and I believe it's nothing more than user-hostile.
There was a problem hiding this comment.
So rather than allow some trusted users to have access to a better Vivecraft experience you want server admins to choose between either giving everyone access to game-breaking functionality or not providing a better integration at all? I don't see the logic in that... do I really need to waste time writing a mod to exploit this?
This adds permissions to all commands (default to the previous op value besides the checkforupdate one which was changed to op too as players should not be able to change that value in the config...) and one for using the server integration. (
vive.use, allowed by default so it behaves like before) Also moved the climb bypass permission to the plugin.yml to actually be registered properly. (Default is the same as before: op)Also use alias for the command instead of registering it twice, update old server version in build.gradle and add all permissions to readme.