Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👍 update dependency for debian package #122

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

chuoru
Copy link
Contributor

@chuoru chuoru commented Nov 26, 2024

OS: Ubuntu 22.04
After installing librbdyn-dev on clean environment withour pre-installed boost such as libboost-all-dev, the following error happened when use find_package(RBDyn REQUIRED):

CMake Error at /usr/local/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find Boost (missing: Boost_INCLUDE_DIR system)
Call Stack (most recent call first):
  /usr/local/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/share/cmake-3.31/Modules/FindBoost.cmake:2409 (find_package_handle_standard_args)
  /usr/local/share/cmake-3.31/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /usr/lib/x86_64-linux-gnu/cmake/RBDyn/RBDynConfig.cmake:158 (find_dependency)
  CMakeLists.txt:9 (find_package)

As mentioned in main CMakeLists.txt, at least boost system is needed for unpacking this project.

...
  # Note: technically we don't need system but it is likely to be here and CMake
  # <= 3.5.0 needs at least one component to define Boost::boost
  add_project_dependency(Boost REQUIRED COMPONENTS system)
endif()

Therefore, in order to use librbdyn-dev in environment without pre-installed libboost-system-dev, we can add libboost-system-dev into debian/control so it will be installed when librbdyn-dev is installed.

@ThomasDuvinage ThomasDuvinage merged commit e429070 into jrl-umi3218:master Nov 27, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants