Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace as.character with format for R4.3 #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klin333
Copy link

@klin333 klin333 commented Nov 13, 2023

in R4.3 the following could give warning:

rhandsontable::rhandsontable(data.frame(x = Sys.Date()))
# Warning message:
# In as.character.POSIXt(as.POSIXlt(x), ...) :
#   as.character(td, ..) no longer obeys a 'format' argument; use format(td, ..) ?

This pull request fixes it

@petersmp
Copy link

I am also running into this issue. It looks like this PR would fix the issue.

@J-flem
Copy link

J-flem commented Jul 30, 2024

Thank you for this branch @klin333. Hopefully it can be pulled into the main branch soon

@jjjpellinen
Copy link

Ran into this issue a year ago #427.

This will fix it. And somehow it seems surprisingly time consuming to merge these 2 lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants