Add additional attr callbacks for session_cb #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are called by at least the default net-http gem, so we need these methods to be present. I am not sure how much functionality they need to have; in CRuby, they are just bound as attr readers/ writers. See #249 and jruby/jruby#7088
|
most |
|
The feature detect fix is better. We still need to revisit these callbacks but my PR is only partial and would silently pretend the callbacks are working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are called by at least the default net-http gem, so we need
these methods to be present. I am not sure how much functionality
they need to have; in CRuby, they are just bound as attr readers/
writers.
See #249 and jruby/jruby#7088