Improved interoperability with ES6 classes #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? |
|
Sorry, it slipped through the cracks. Is it possible to get tests added for this? I can look into adding them too. Ideally es6 classes to make sure we don't break it in the future. |
|
Sure no problem. Whenever I have some time I will write a couple tests based on the use case that we encountered on our project |
|
@dougwilson it's done. I could only come up with one test since the change is very small and it's the only case where it broke (i.e. directly extending HttpError). Let me know if I should add something more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #98