Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterMaskImageWithSize: Filter mask image with its size #2062

Merged
merged 4 commits into from
Apr 26, 2017

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Apr 19, 2017

Modified:

  • jsk_perception/CMakeLists.txt
  • jsk_perception/include/jsk_perception/multiply_mask_image.h
  • jsk_perception/plugins/nodelet/libjsk_perception.xml Added:
  • jsk_perception/cfg/FilterMaskImageWithSize.cfg
  • jsk_perception/include/jsk_perception/filter_mask_image_with_size.h
  • jsk_perception/src/filter_mask_image_with_size.cpp

filter_mask_image_with_size

@wkentaro wkentaro force-pushed the filter_mask_with_size branch 3 times, most recently from 40a82a8 to 98a840c Compare April 19, 2017 10:03
@wkentaro wkentaro requested review from otsubo, knorth55 and mukuact April 19, 2017 11:16
@wkentaro wkentaro changed the title Filter mask image with its size FilterMaskImageWithSize: Filter mask image with its size Apr 19, 2017
@k-okada
Copy link
Member

k-okada commented Apr 20, 2017

@wkentaro I have resolved conflict via web interface, so please confirm if that is ok.

@wkentaro wkentaro force-pushed the filter_mask_with_size branch 2 times, most recently from 4e83c0e to e634a00 Compare April 20, 2017 04:45
Modified:
  - jsk_perception/CMakeLists.txt
  - jsk_perception/include/jsk_perception/multiply_mask_image.h
  - jsk_perception/plugins/nodelet/libjsk_perception.xml
Added:
  - jsk_perception/cfg/FilterMaskImageWithSize.cfg
  - jsk_perception/include/jsk_perception/filter_mask_image_with_size.h
  - jsk_perception/src/filter_mask_image_with_size.cpp
-	new file:   doc/jsk_perception/nodes/filter_mask_image_with_size.md
-	new file:   doc/jsk_perception/nodes/images/filter_mask_image_with_size.gif
-	modified:   jsk_perception/CMakeLists.txt
-	new file:   jsk_perception/sample/sample_filter_mask_image_with_size.launch
-	new file:   jsk_perception/test/filter_mask_image_with_size.test
@wkentaro wkentaro force-pushed the filter_mask_with_size branch from e634a00 to 1493179 Compare April 20, 2017 04:46
@wkentaro
Copy link
Member Author

Thanks. I rebased.

@knorth55
Copy link
Member

I approved, but i don't see usecase of this nodelet. (Sample launch subscribe same mask image.)

- modified:   ../doc/jsk_perception/nodes/filter_mask_image_with_size.md
- modified:   include/jsk_perception/filter_mask_image_with_size.h
- modified:   sample/sample_filter_mask_image_with_size.launch
- modified:   src/filter_mask_image_with_size.cpp
@wkentaro
Copy link
Member Author

I added flag ~use_reference to minimize the overhead caused by synchronizing.

@wkentaro
Copy link
Member Author

@knorth55 Could u Please check the latest commit?

@wkentaro
Copy link
Member Author

Please merge this.

@k-okada k-okada merged commit 50702ee into jsk-ros-pkg:master Apr 26, 2017
@wkentaro wkentaro deleted the filter_mask_with_size branch April 26, 2017 15:41
@k-okada
Copy link
Member

k-okada commented Apr 26, 2017

You can also use back projection method for detection motion area , if the camera is fixed on world frame-> ros-perception/opencv_apps#62
note that a camera with automatic white balance features does not work well with that algorithm, you'd better to use good camera. > @wkentaro

And if we can assume the moving object is human, we can use that for human detection application -> http://goldberg.berkeley.edu/pubs/acc-2012-visual-tracking-final.pdf > @kochigami @furushchev

This algorithm combines statistical background image estimation and per-pixel Bayesian segmentation. It was introduced by Andrew B. Godbehere, Akihiro Matsukawa, Ken Goldberg in their paper “Visual Tracking of Human Visitors under Variable-Lighting Conditions for a Responsive Audio Art Installation” in 2012. As per the paper, the system ran a successful interactive audio art installation called “Are We There Yet?” from March 31 - July 31 2011 at the Contemporary Jewish Museum in San Francisco, California.

@wkentaro
Copy link
Member Author

You can also use back projection method for detection motion area , if the camera is fixed on world frame-> ros-perception/opencv_apps#62
note that a camera with automatic white balance features does not work well with that algorithm, you'd better to use good camera. > @wkentaro

Thank you for the info.

And if we can assume the moving object is human, we can use that for human detection application

I tried using fcn_object_segmentation.py for person detection for object data collection, but it was a bit difficult to segment the person and him/her holding objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants