Change API to satisfies(SPDX Expression, Array of Approved Licenses)
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The design decision to take the argument expressing acceptable license policy as another SPDX expression has repeatedly confused people. Meanwhile, the primary use case for this package is to check some SPDX license expression for a package against a list of approved licenses. I believe we can better serve that use case and make this package easier to maintain by taking a list of approved licenses instead of a second SPDX expression.
ES6 is pretty old now, but we try to support old Node.js versions.
Current Tape does not support some of the very old versions we do.
Generating README.md is fine for npmjs.com, but not so much for GitHub, where README.md is also the "welcome page" to the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design decision to take the argument expressing acceptable license policy as another SPDX expression has repeatedly confused people. It's far from clear how an algorithm should go about comparing AND and OR expressions to other AND and OR expressions. Meanwhile, the primary use case for this package is to check some SPDX license expression for a package against a list of approved licenses.
I believe we can better serve that use case and make this package easier to maintain by taking a list of approved licenses instead of a second SPDX expression.