Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links not adhering to its meta-schema given invalid dependencies #1576

Open
wants to merge 1 commit into
base: draft-04
Choose a base branch
from

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jan 17, 2025

@jeremyfiel
Copy link

i don't see this file in main. seems like they restructured at some point when they removed the hyper schema stuff

@jeremyfiel
Copy link

#1326

@jviotti
Copy link
Member Author

jviotti commented Jan 17, 2025

@jeremyfiel I'm targeting Draft 4 though. main always has next as far as I understand

@jeremyfiel
Copy link

I suppose that's true

But these changes should probably go to the hyper schema repo linked

@gregsdennis
Copy link
Member

gregsdennis commented Jan 17, 2025

I don't understand what you're asking for here. The definition of dependencies in the draft 4 meta-schema is

    "dependencies": {
      "type": "object",
      "additionalProperties": {
        "anyOf": [
          { "$ref": "#" },
          { "$ref": "#/definitions/stringArray" }
        ]
      }
    },

Source: https://json-schema.org/draft-04/schema#/properties/dependencies

This is consistent with the language of the specification: an object where each property (individually) must be a schema or an array of strings.

@jviotti
Copy link
Member Author

jviotti commented Jan 17, 2025

@gregsdennis

an object where each property (individually) must be a schema or an array of strings.

Correct, but on the schema I'm linking, it is set to just a string, and not an array of strings?

@jdesrosiers
Copy link
Member

@jviotti Good catch! A string was a valid value for dependencies in draft-03 and apparently this constraint didn't get updated when it was moved to the links.json schema in draft-04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants