Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added linting in the workflow #290

Closed
wants to merge 2 commits into from
Closed

fix: added linting in the workflow #290

wants to merge 2 commits into from

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Feb 5, 2024

GitHub Issue: #289

Summary:

Added linting of pr in every pr

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No
[JUSTIFICATION]

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I haven't tested it locally but the action seems to run.
Unclear if it is running against any of the files or just finding no results.

runs-on: ubuntu-latest
steps:
- name: Checkout the Repository
uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to use actions/checkout@v4 (at least). Node.js version bump.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gmin2
Copy link
Contributor Author

Gmin2 commented Feb 8, 2024

Thanks for this PR. I haven't tested it locally but the action seems to run. Unclear if it is running against any of the files or just finding no results.

Thanks for this PR. I haven't tested it locally but the action seems to run. Unclear if it is running against any of the files or just finding no results.

i have tested this action locally here

@Gmin2 Gmin2 requested a review from Relequestual February 8, 2024 13:37
@Gmin2 Gmin2 closed this by deleting the head repository Feb 8, 2024
@Gmin2
Copy link
Contributor Author

Gmin2 commented Feb 8, 2024

mistakenly deleted my forked repo 🤦‍♀️. Can you give me an idea how do i recover my repo

cc @Relequestual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants