-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed UI of blog page #420
Conversation
Mention #412 in your pr it will add on that issue pr , so maintainer can review or understand easily .., it can make easy to access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an amazing pr @TamannaVerma99 but can you pls. remove unwanted changes done by prettier extension so that it will be easy for maintainers to review the actual changes.
Also pls. add pr title suggesting the changes done.
Thank You : )
@TamannaVerma99 , If you remove prettier changes then it will throw eslint error. Make sure you have fetch the latest changes before working on issue. Thank You : ) |
Thank you so much for your suggestions, Really appreciate them! |
Basically we do already setup the prettier and eslint. Just fetch the latest changes : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay ,I will do the required! Thanks for the feedback :) |
Made the required changes @benjagm . The text is now aligned at the center for desktop view. However, it is quite improbable to do the same on all screen sizes, given the inclined nature of the image. But have tried my best to ensure appropriate text alignment accordingly on all remaining screen sizes. |
@benjagm can you please have a look on it? |
@@ -4,6 +4,24 @@ module.exports = { | |||
'./components/**/*.{js,ts,jsx,tsx,md}', | |||
], | |||
theme: { | |||
screens: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this screens declaration necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just left a comment regarding editing tailwind.config.js. I am not sure if the new code there is necessary.
@benjagm in order to add custom screen sizes in Tailwind, its necessary to specify the default screen sizes as well to prevent overwriting them. So, needed to add them as well along with the new custom size (ab1 :'890px') |
Hey @TamannaVerma99, it seems like you haven't formatted the code with Prettier. Now, when I fetch the latest changes, I'm getting ESLint errors for the file you've edited. Did you bypass the Husky pre-commit checks? I think you should format and check for ESLint errors before pushing your code. Otherwise, it could create problems for other contributors who are working on the project. Well, we've recently implemented a PR workflow where we check formatting, ESLint, and type checking. This should prevent this type of issues in the future. @benjagm, this needs to be fixed as soon as possible. You can either revert this PR or fix the issue from your end. Thank you : ) |
Fixed in production. Thanks everyone. |
What kind of change does this PR introduce?
A bugfix
Issue Number:
Resolves #412 & #427
Summary
I've made appropriate improvements to the CSS properties of the blog landing page to ensure responsiveness across all screen sizes. Additionally, I've enhanced the picture size on the landing page for better visual appeal and readability. These changes aim to create a more user-friendly and visually engaging experience for visitors accessing the blog. Also, fixed the image size to eliminate issues caused by too much padding.