Feat/newsletter #681
Closed
Feat/newsletter #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son-schema-org#460) * Standardize List Display with Card Component (json-schema-org#433) * Addressed comments, added images, and implemented new styles * Increased padding on the x-axis
* updated UI of blog-page * Added Case Studies Page * fixed linting errors * Added casestudies * changing index.page.tsx * Delete components/CustomComponent.tsx * Delete pages/overview/casestudies.md * removed unnecessary changes * removed unnecessary files * fixed bug * removed changes * removed unnecessary files * Pushing last changes. --------- Co-authored-by: Benjamin Granados <[email protected]>
* fixed * feat: added resource section * feat: added resource section * revert changes cd6d848 * revert changes 65e9f3e * revert changes 877b0f0 * revert changes 74711cd * fix: fixed the width issue * revert change * fix: added resource icon * Tiny changes to adjust look and feel. * Last changes to fix dark theme --------- Co-authored-by: Benjamin Granados <[email protected]>
* initialize the Test directory. * Added the subscribe button. * Added the subscribe page. * Added the newsletter page. * changed name to newsletter. * removed the unwated code. * removed the unwated components. * decreased the horizontal width and changed the color. * decreased the font size. * Added the changes for the newsletter banner. * Added the newletter component to landing page. * added the color for input. * Added the required horizontal padding. * Added the required horizontal padding. for newsletter page. * Add changes to make it work with mailchimp * added the yarn file back. * Added yarn.lock file. * Update yarn.lock * linted the newsletter.tsx * linted newsletter * fix the index.page * Small improvement in page layout. * Fix dark theme behavior * . --------- Co-authored-by: AyushNautiyalDeveloper <[email protected]> Co-authored-by: Benjamin Granados <[email protected]>
* added welcome page * Pushed some changes to changes - Better location in sidebar - Changes to move what is json schema into getting started - move page inside overview --------- Co-authored-by: Benjamin Granados <[email protected]>
* added use-cases page, modified card component * fix * Added some changes to better merge with the dev branch. --------- Co-authored-by: Benjamin Granados <[email protected]>
* docs: added definition of json hyper-schema * fixed * fix: spacing b/w buttons * fix: added spacing in mobile design * fix: spacing on tablet screen * fix: spacing on less than 300px screen
* community-page * Some final changes for the community page --------- Co-authored-by: Benjamin Granados <[email protected]>
…rg#657) * cleaning * changing axios to fs * Remove articles from sidebar --------- Co-authored-by: Benjamin Granados <[email protected]>
benjagm
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Great first step!!
Now we have the data and the functionality and we only need to improve design and user experience:
- Improve the hero section to replace the current subscribe form for a two columns design like Kubeweekly.
Column 1 : title, subtitle and link to submit content | Column 2 : Subscribe form.
- The area to show the newsletters require some changes:
- Remove the title "Previous JSON Schema Newsletter" and replace it for grouping by Year, in this case "2024". The left margin/padding needs to be fixed.
- Better to change the background color of this area with a light grey.
- The newsletters needs to be sorted in descending order from newest to oldest.
Great progress here!! Thanks!!
|
Thank you @Akshaybagai52 can you pls. change the destiny branch to |
Okay |
Akshaybagai52
changed the base branch from
web-release-3
to
web-release-newsletter
I've changed the destiny branch |
|
Hi Akshay there is a lot of unnecessary files in the PR. I think the best way to proceed to avoid this will be:
Otherwise it will be difficult to integrate. I know that this was not supposed to be needed but finally we needed to change the release date of the newsletter and remove from release 3. Thanks a lot! |
This is new PR link :- #733 |
|
Closed in favour of #733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?