fix: additional property casted into int when actually is numeric string

jsonrainbow · Feb 11, 2025 · 18636f0 · 18636f0
1 parent 7660882
commit 18636f0
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/src/JsonSchema/Constraints/ObjectConstraint.php b/src/JsonSchema/Constraints/ObjectConstraint.php
@@ -159,7 +159,7 @@ protected function &getProperty(&$element, $property, $fallback = null)
     {
         if (is_array($element) && (isset($element[$property]) || array_key_exists($property, $element)) /*$this->checkMode == self::CHECK_MODE_TYPE_CAST*/) {
             return $element[$property];
-        } elseif (is_object($element) && property_exists($element, $property)) {
+        } elseif (is_object($element) && property_exists($element, (string) $property)) {
             return $element->$property;
         }
 

diff --git a/tests/Constraints/AdditionalPropertiesTest.php b/tests/Constraints/AdditionalPropertiesTest.php
@@ -189,6 +189,42 @@ public function getValidTests(): array
                   "additionalProperties": true
                 }'
             ],
+            [
+                '{
+                  "prop1": {
+                    "prop2": "a"
+                  }
+                }',
+                '{
+                  "type": "object",
+                  "additionalProperties": {
+                    "type": "object",
+                    "properties": {
+                      "prop2": {
+                        "type": "string"
+                      }
+                    }
+                  }
+                }'
+            ],
+            [
+                '{
+                  "prop1": {
+                    "123": "a"
+                  }
+                }',
+                '{
+                  "type": "object",
+                  "additionalProperties": {
+                    "type": "object",
+                    "properties": {
+                      "123": {
+                        "type": "string"
+                      }
+                    }
+                  }
+                }'
+            ],
         ];
     }
 }