Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use phpstan's int-mask-of<T> #779

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

jack-worman
Copy link
Contributor

@jack-worman jack-worman commented Feb 4, 2025

We are getting phpstan errors when using multiple options of the checkmode (i.e. Constraint::CHECK_MODE_VALIDATE_SCHEMA | Constraint::CHECK_MODE_EXCEPTIONS)

@jack-worman jack-worman changed the title Use phpstan's int-mask-of<T> for checkmode Use phpstan's int-mask-of<T> Feb 4, 2025
@DannyvdSluijs
Copy link
Collaborator

@jack-worman great improvement, could you also add an entry to the changelog under ## [Unreleased] following the format from the other lines.
And the PHPStan workflow seems to highlight some issues that might need some looking into.

@jack-worman
Copy link
Contributor Author

CI should be fixed now.

@DannyvdSluijs DannyvdSluijs merged commit 56f34b8 into jsonrainbow:master Feb 6, 2025
14 checks passed
@jack-worman jack-worman deleted the patch-1 branch February 7, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants