Merge pull request #3213 from jspsych/add-response-ends-trial-vs-circle

Fix display clearing bug in visual search circle plugin version 1.2.0 (rebased-with-history from commit daea41b)
jspsych · Jun 7, 2024 · d431e03 · d431e03
2 parents 7926236 + daea41b
commit d431e03
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/.changeset/clever-coats-invent.md b/.changeset/clever-coats-invent.md
@@ -0,0 +1,5 @@
+---
+"@jspsych/plugin-visual-search-circle": patch
+---
+
+Fix display clearing problem introduced with version 1.2.0
diff --git a/packages/plugin-visual-search-circle/src/index.spec.ts b/packages/plugin-visual-search-circle/src/index.spec.ts
@@ -28,6 +28,8 @@ describe("visual-search-circle", () => {
     await pressKey("a");
     await expectFinished();
 
+    expect(displayElement.querySelectorAll("img").length).toBe(0);
+
     expect(getData().values()[0].correct).toBe(true);
   });
 
@@ -58,6 +60,8 @@ describe("visual-search-circle", () => {
     jest.runAllTimers();
     await expectFinished();
 
+    expect(displayElement.querySelectorAll("img").length).toBe(0);
+
     expect(getData().values()[0].correct).toBe(true);
   });
 });

diff --git a/packages/plugin-visual-search-circle/src/index.ts b/packages/plugin-visual-search-circle/src/index.ts
@@ -166,6 +166,8 @@ class VisualSearchCirclePlugin implements JsPsychPlugin<Info> {
     };
 
     const end_trial = () => {
+      display_element.innerHTML = "";
+
       this.jsPsych.pluginAPI.clearAllTimeouts();
       this.jsPsych.pluginAPI.cancelAllKeyboardResponses();