Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Survey plugin updates: fix CSS, clean up code/comments, add survey.css to dist archive #3287

Merged
merged 6 commits into from
May 14, 2024
Merged

Survey plugin updates: fix CSS, clean up code/comments, add survey.css to dist archive #3287

merged 6 commits into from
May 14, 2024

Conversation

becky-gilbert
Copy link
Collaborator

This PR updates the survey plugin with the following changes:

Fixes #3131
Fixes #3286

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 24d82dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@jspsych/config Patch
@jspsych/plugin-survey Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@becky-gilbert becky-gilbert marked this pull request as ready for review May 9, 2024 23:30
@becky-gilbert becky-gilbert requested review from bjoluc and jodeleeuw May 9, 2024 23:30
@jodeleeuw
Copy link
Member

@becky-gilbert I think we can go ahead and merge this if you're ready

@becky-gilbert becky-gilbert merged commit 54e04dc into main May 14, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 14, 2024
Merged
bjoluc pushed a commit that referenced this pull request Jun 7, 2024
@becky-gilbert @bjoluc
Survey plugin updates: fix CSS, clean up code/comments, add survey.cs…
ad03a8b 
…s to dist archive (#3287)

* make applyStyles private and clean up comments
* fix box shadow in input elements
* fix dropdown element width
* remove old/unused plugin-survey.css file
* add survey.css to dist archive
* add changeset

(rebased-with-history from commit 54e04dc)
@bjoluc bjoluc deleted the survey-plugin-updates branch June 7, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodeleeuw jodeleeuw jodeleeuw approved these changes

@bjoluc bjoluc Awaiting requested review from bjoluc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect width for jsPsychSurvey dropdown options survey.css not shipped in latest release
2 participants
@becky-gilbert @jodeleeuw