Simplify .-section-x-inset-xl CSS
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nicolo-ribaudo
force-pushed
the
simplyfy-section-x-inset-xl-css
branch
from
14ddaa2 to
ee4d42d
Compare
lucacasonato
approved these changes
Feb 10, 2025
lucacasonato
added a commit
that referenced
this pull request
Feb 10, 2025
This reverts commit 31c1e76.
|
This broke the footer.
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
… not block (#950) Fixes #945 (comment). Only tested by changing the value in the browser devtools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first three
calc()expressions,100vwis less than1280px(otherwise we'd be in thescreen(xl)media query), somin(1280px, 100vw)is just a complex way to say100vw, and thuscalc((100vw - (min(1280px, 100vw) - 32px)) / 2 * -1)is just a very complex way to say-16px. I simplified them to the corresponding-mx-classes, so that it's clear that they are the same numbers used in.section-x-inset-xl.In the last
calc(),100vwis always more than1280px(because of the media query), somin(1280px, 100vw)is just a complex way of saying1280px. I left1280px - 112pxwhich is hopefully more clear than just writing1068px.Note that using
100vwinstead of1280pxin the last one would fix the bug reported in #944, but I'm assuming thatmin(1280px, 100vw)is there for a reason so I cannot simply remove it.Edit: The second commit fixes #944, by using the page width excluding the vertical scrollbar rather than using the full page width to compute the sticky breadcrumb margin.