fix(jstz_proto): handle tx correctly in Script.run

jstz-dev · Feb 3, 2025 · 4a11f1a · 4a11f1a
1 parent f8ae950
commit 4a11f1a
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/crates/jstz_proto/src/executor/smart_function.rs b/crates/jstz_proto/src/executor/smart_function.rs
@@ -298,14 +298,13 @@ impl Script {
             result,
             |value, _context| {
                 runtime::with_js_hrt_and_tx(|hrt, tx| -> JsResult<()> {
-                    let response = Response::try_from_js(value)?;
-
-                    // If status code is 2xx, commit transaction
-                    if response.ok() {
-                        tx.commit(hrt)?;
-                    } else {
-                        tx.rollback()?;
-                    }
+                    match Response::try_from_js(value) {
+                        // commit if the value returned is a response with a 2xx status code
+                        Ok(response) if response.ok() => {
+                            tx.commit(hrt)?;
+                        }
+                        _ => tx.rollback()?,
+                    };
 
                     Ok(())
                 })