fea(cli): bridge fa deploy cli command #778
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcabter
force-pushed
the
ryan-jstz-173/bridge-fa-deploy-cli-command
branch
from
3fa7edc to
708b929
Compare
zcabter
force-pushed
the
ryan-jstz-173/bridge-fa-deploy-cli-command
branch
from
708b929 to
a052ca1
Compare
ryutamago
reviewed
Jan 24, 2025
| "Pair {{}} ({}) ({}) {}", | ||
| fa_token_object.to_micheline(), | ||
| format_ticket_content(ticket_id, ticket_content)?, | ||
| total_ticket_supply |
There was a problem hiding this comment.
does thistoatal_ticket_supply have to do with the the total supply of the fa token?
maybe leave a comment that this ticket represents the number of tokens that can be bridged to L2?
| @@ -427,6 +427,17 @@ impl JstzdServer { | |||
|
|
|||
| Ok(jstzd) | |||
| } | |||
|
|
|||
| pub async fn get_config(&self) -> JstzdConfig { | |||
| &source.to_base58(), | ||
| JSTZ_FA_BRIDGE, | ||
| &bridge_storage, | ||
| )?; |
There was a problem hiding this comment.
nit
add error message for bridge deployment failed but ticket suceeds
ryutamago
reviewed
Jan 27, 2025
| @@ -42,6 +42,8 @@ pub enum Command { | |||
| #[arg(short, long, default_value = None)] | |||
| network: Option<NetworkName>, | |||
| }, | |||
| /// Deploys an FA token bridge with minimal functionality. | |||
There was a problem hiding this comment.
nit:
i found it hard to understand the bridge mechanism at the start, could briefly mention in jstz, bridge consists of the birdge contract and the ticketer etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Convenience command to deploy an FA bridge given an L1 fa contract and Jstz token contract that implements the deposit endpoint.
Description
bridge fa-deploycommand and all the necessary contracts with itUnfortunately, test coverage is poor due to the disabled CI test
Manually testing the PR
Integration tests:
cargo test -p jstz_cli fa_deploy_testManual test