Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set default octez tag for images #787

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Jan 24, 2025

Context

Part of JSTZ-286.
JSTZ-286

Description

Set default octez tag for builds triggered by tag events. Normally when the workflow is triggered, an input value octez-tag is provided, but when the workflow is triggered by a tag event, there is no way of getting that value, so we need to set a default value. This value should be identical to the octez version that is used during development and testing, in our case, in nix, but currently the default value set in this PR is different from that nix version because the nix version does not work well and I don't have enough time figuring out how to update that for now.

Manually testing the PR

Tested by temporarily setting the workflow input octez-tag to optional and triggered a run without any input value. The test run still worked and the default value was set.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.34%. Comparing base (c4d0658) to head (2314636).
Report is 1 commits behind head on main.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d0658...2314636. Read the comment docs.

@huancheng-trili huancheng-trili marked this pull request as ready for review January 24, 2025 06:48
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-286 branch 2 times, most recently from c2159dc to eecef17 Compare January 24, 2025 12:34
Base automatically changed from huanchengchang-jstz-286 to main January 24, 2025 12:38
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-286-1 branch from 0425398 to 2314636 Compare January 24, 2025 12:39
@huancheng-trili huancheng-trili enabled auto-merge (rebase) January 24, 2025 12:40
@huancheng-trili huancheng-trili merged commit 59c51f2 into main Jan 24, 2025
3 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-286-1 branch January 24, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants