Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jstzd): remove job limit in docker build #788

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Jan 24, 2025

Context

Closes JSTZ-286.
JSTZ-286

Description

Remove the job limit in building docker images for jstzd. The config value --jobs was set to prevent the system from using too much resource during cross-compilation, but now there is no need to do cross-compilation, this config value can be removed to speed up the build process.

Manually testing the PR

N/A

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.34%. Comparing base (59c51f2) to head (00376b8).
Report is 1 commits behind head on main.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c51f2...00376b8. Read the comment docs.

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-286-2 branch from dc4b8f5 to 9add33c Compare January 24, 2025 07:20
@huancheng-trili huancheng-trili marked this pull request as ready for review January 24, 2025 07:35
Copy link
Collaborator

@ryutamago ryutamago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE🛳️

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-286-1 branch from 0425398 to 2314636 Compare January 24, 2025 12:39
Base automatically changed from huanchengchang-jstz-286-1 to main January 24, 2025 12:42
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-286-2 branch from 9add33c to 00376b8 Compare January 24, 2025 12:43
@huancheng-trili huancheng-trili enabled auto-merge (rebase) January 24, 2025 12:45
@huancheng-trili huancheng-trili merged commit 83397a6 into main Jan 24, 2025
3 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-286-2 branch January 24, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants