Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewAddress -> Address #791

Merged
merged 2 commits into from
Feb 3, 2025
Merged

NewAddress -> Address #791

merged 2 commits into from
Feb 3, 2025

Conversation

ryutamago
Copy link
Collaborator

@ryutamago ryutamago commented Jan 27, 2025

Context

final step of migration to support KT1 address
task link

Description

  • rename the new_account, NewAddress back to account and Address
  • avoid unnecessary clone inside jstz_proto

Manually testing the PR

existing test works

@ryutamago ryutamago changed the title chore: rename address NewAddress -> Address Jan 27, 2025
@ryutamago ryutamago self-assigned this Jan 27, 2025
@ryutamago ryutamago requested a review from zcabter January 27, 2025 11:16
@ryutamago ryutamago assigned zcabter and unassigned ryutamago Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 77.85714% with 31 lines in your changes missing coverage. Please review.

Project coverage is 49.54%. Comparing base (03d3f90) to head (f8ae950).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstz_cli/src/config.rs 0.00% 5 Missing ⚠️
crates/jstz_cli/src/jstz.rs 0.00% 5 Missing ⚠️
crates/jstz_cli/src/utils.rs 20.00% 3 Missing and 1 partial ⚠️
crates/jstz_proto/src/api/ledger.rs 0.00% 4 Missing ⚠️
crates/jstz_proto/src/executor/mod.rs 0.00% 4 Missing ⚠️
crates/jstz_cli/src/repl/debug_api/account.rs 50.00% 0 Missing and 2 partials ⚠️
crates/jstz_cli/src/run.rs 0.00% 2 Missing ⚠️
crates/jstz_kernel/src/inbox.rs 33.33% 1 Missing and 1 partial ⚠️
crates/jstz_proto/src/api/smart_function.rs 71.42% 2 Missing ⚠️
crates/jstz_kernel/src/parsing.rs 83.33% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
crates/jstz_cli/src/bridge/deposit.rs 0.00% <ø> (ø)
crates/jstz_cli/src/bridge/withdraw.rs 0.00% <ø> (ø)
crates/jstz_cli/src/deploy.rs 0.00% <ø> (ø)
crates/jstz_kernel/src/lib.rs 88.80% <100.00%> (ø)
crates/jstz_node/src/services/accounts.rs 44.17% <ø> (ø)
crates/jstz_node/src/services/logs/mod.rs 51.11% <ø> (ø)
crates/jstz_proto/src/context/account.rs 88.31% <100.00%> (ø)
crates/jstz_proto/src/context/mod.rs 32.15% <ø> (ø)
crates/jstz_proto/src/context/ticket_table.rs 94.76% <100.00%> (ø)
crates/jstz_proto/src/executor/deposit.rs 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d3f90...f8ae950. Read the comment docs.

@ryutamago ryutamago marked this pull request as ready for review January 27, 2025 12:06
@ryutamago ryutamago force-pushed the leounoki-jstz-253/rename-address branch from f9f0df7 to 44589ac Compare January 28, 2025 17:23
@zcabter
Copy link
Collaborator

zcabter commented Jan 30, 2025

Could you also fix jstz_node/src/services/logs/{mod.rs, db.rs} please?

@zcabter zcabter assigned ryutamago and unassigned zcabter Jan 30, 2025
@ryutamago ryutamago force-pushed the leounoki-jstz-253/rename-address branch from 44589ac to a3d8f91 Compare January 30, 2025 16:04
@ryutamago ryutamago force-pushed the leounoki-jstz-253/rename-address branch from a3d8f91 to f8ae950 Compare January 30, 2025 16:09
@ryutamago ryutamago assigned zcabter and unassigned ryutamago Jan 30, 2025
Copy link
Collaborator

@zcabter zcabter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zcabter zcabter assigned ryutamago and unassigned zcabter Feb 3, 2025
@ryutamago ryutamago merged commit 39a5ff0 into main Feb 3, 2025
5 checks passed
@ryutamago ryutamago deleted the leounoki-jstz-253/rename-address branch February 3, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants