Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstz_proto): implement refund in response #849

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryutamago
Copy link
Collaborator

@ryutamago ryutamago commented Mar 4, 2025

Context

task
Handle refund via Response object in smart function.

Description

  • try_apply_to_value_or_promise now takes a closure bounded by 'static lifetime
  • the refund initiated by Response object DOES NOT propogate to more than one level unless it's explicitly specified.

Manually testing the PR

  • unit test: cargo test -p jstz_proto
  • manual test with tranfer.js script

@ryutamago ryutamago force-pushed the leounoki/jstz-330-response4 branch from e94cefb to e75aed8 Compare March 4, 2025 15:52
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 98.56322% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.68%. Comparing base (c762d73) to head (94c9d3a).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstz_proto/src/executor/smart_function.rs 92.10% 0 Missing and 3 partials ⚠️
crates/jstz_proto/src/api/smart_function.rs 99.35% 0 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
crates/jstz_proto/src/api/smart_function.rs 91.51% <99.35%> (+3.65%) ⬆️
crates/jstz_proto/src/executor/smart_function.rs 92.35% <92.10%> (+0.53%) ⬆️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c762d73...94c9d3a. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant