Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build static x64 cli binary #856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Mar 7, 2025

Context

Completes JSTZ-345.
JSTZ-345

Description

Build CLI for x86_64-unknown-linux-musl in order to get static x64 cli binaries.

I tried to use pkgsMusl in nix, but nix tried to rebuild a whole bunch of irrelevant packages for musl, which took hours, and in the end there were some error in those in irrelevant packages, and again mozjs does not have a prebuilt for x86_64-unknown-linux-musl, so I'm building this as how it's done for aarch64-linux.

Manually testing the PR

Test workflow run

Also tested the built binary in a clean x64 environment.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.67%. Comparing base (c208e95) to head (4612fd0).
Report is 7 commits behind head on main.

see 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c208e95...4612fd0. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huancheng-trili huancheng-trili force-pushed the huanchengchang/jstz-345 branch from c03f6b9 to 4612fd0 Compare March 7, 2025 10:11
@huancheng-trili huancheng-trili marked this pull request as ready for review March 7, 2025 11:17
@huancheng-trili huancheng-trili requested a review from zcabter March 7, 2025 11:17
@zcabter
Copy link
Collaborator

zcabter commented Mar 7, 2025

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants