[New] label-has-associated-control: allow labelComponents to contain globs
#1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain globs Add ability for `labelComponents` within the `label-has-associated-control` to use the same glob checking mechanism as `controlComponents`. - Ensure existing tests pass and update unit tests for new behaviour - Add extra tests for documented `???Foo` syntax for component glob matching - Update documentation to have appropriate examples for label/control glob usage Closes jsx-eslint#972
|
Note to self. Need to rebase to resolve conflicts. |
lb-
force-pushed
the
feature/972-label-has-associated-control-glob-label-component
branch
from
16e355b to
d84726f
Compare
ljharb
force-pushed
the
feature/972-label-has-associated-control-glob-label-component
branch
from
d84726f to
743168b
Compare
ljharb
changed the title
labelComponents glob checks in label-has-associated-controllabel-has-associated-control: allow labelComponents to contain globs
ljharb
approved these changes
Oct 27, 2024
lb-
deleted the
feature/972-label-has-associated-control-glob-label-component
branch
|
Thank you @ljharb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability for
labelComponentswithin thelabel-has-associated-controlto use the same glob checking mechanism ascontrolComponents.???Foosyntax for component glob matchingBuilds on PR #1024