Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove es-iterator-helpers dependency #1030

Merged

Conversation

MichaelDeBoey
Copy link
Contributor

No description provided.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dep is still needed until node 20 is dropped.

@ljharb ljharb marked this pull request as draft October 25, 2024 01:59
@MichaelDeBoey
Copy link
Contributor Author

@ljharb Can you explain why?

aria-query returns normal arrays as of v5 for all *.keys() & *.values(), so we don't need iterator helpers and can just use built-in array functionality?
https://github.com/A11yance/aria-query/blob/main/CHANGELOG.md#500

@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review October 25, 2024 02:02
@MichaelDeBoey MichaelDeBoey requested a review from ljharb October 25, 2024 02:02
@ljharb
Copy link
Member

ljharb commented Oct 25, 2024

aha, you're right. in that case, this PR should be able to go to main instead of breaking, yes?

@MichaelDeBoey
Copy link
Contributor Author

@ljharb Those array functions didn't exist on Node v4 yet, so we can't merge this PR to main

@ljharb
Copy link
Member

ljharb commented Oct 25, 2024

True. but on main we could replace the iterator helpers with array method packages?

@MichaelDeBoey
Copy link
Contributor Author

That would indeed be possible, but that would mean that we need to do 2 PRs: 1 on main to use array method packages + 1 on breaking to remove those packages as well and do what I did in this PR

@MichaelDeBoey MichaelDeBoey force-pushed the remove-es-iterator-helpers-dep branch from c4f18b5 to 09406af Compare October 25, 2024 02:20
@ljharb
Copy link
Member

ljharb commented Oct 25, 2024

True. It'd be nice to have both tho :-) also likely the next time i rebase breaking i'll be removing all the relevant array dep usages you add anyways

@MichaelDeBoey
Copy link
Contributor Author

@ljharb #1020 is already removing all these array function package usages, so I'd rather keep working on breaking to move forward asap tbh

@ljharb ljharb force-pushed the remove-es-iterator-helpers-dep branch from 09406af to ffa0523 Compare October 25, 2024 03:00
@ljharb ljharb force-pushed the remove-es-iterator-helpers-dep branch from ffa0523 to 09b3d13 Compare October 25, 2024 03:02
@ljharb ljharb force-pushed the remove-es-iterator-helpers-dep branch from 09b3d13 to 332fecc Compare October 25, 2024 03:17
@ljharb ljharb merged commit 332fecc into jsx-eslint:breaking Oct 25, 2024
18 checks passed
@MichaelDeBoey MichaelDeBoey deleted the remove-es-iterator-helpers-dep branch October 25, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants