-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove es-iterator-helpers
dependency
#1030
refactor: remove es-iterator-helpers
dependency
#1030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dep is still needed until node 20 is dropped.
@ljharb Can you explain why?
|
aha, you're right. in that case, this PR should be able to go to |
@ljharb Those array functions didn't exist on Node v4 yet, so we can't merge this PR to |
True. but on |
That would indeed be possible, but that would mean that we need to do 2 PRs: 1 on |
c4f18b5
to
09406af
Compare
True. It'd be nice to have both tho :-) also likely the next time i rebase |
09406af
to
ffa0523
Compare
ffa0523
to
09b3d13
Compare
09b3d13
to
332fecc
Compare
No description provided.