-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] don't destructure builtins #1033
[Refactor] don't destructure builtins #1033
Conversation
I actually prefer to do it everywhere - iow, I think this is going the wrong direction. |
@ljharb This is always going to come from |
2e72c76
to
b0fc3a9
Compare
It's not globally, it's at the top level module scope. |
@ljharb Yeah that's what I meant, sorry for the miswording. My opinion is just: from this point onwards, these methods will always come from |
b0fc3a9
to
057b9ac
Compare
That's true, and I suppose I've accepted the risk of environment mutation, so that's not really an argument that applies. |
If people are breaking their environment outside of this plugin, than it's their own fault for breaking it imo. But that's out of scope of this PR I think. |
057b9ac
to
0852aa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased to clean up remaining examples of this pattern.
Object
Introduced in a3c0ffa, but these are the only places we do this.
In all other places we use
Object.*