[patch] label-has-associated-control: improve error messages
#1041
+123
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the error messages of the label-has-associated-control rule so that each assert type gets an error message with verbiage specific to the assertion. I wanted to land this before adding support for matching a label's htmlFor attribute with the associated control's id
michaelfaith
force-pushed
the
feat/improve-messages
branch
from
07ca867 to
bd2637f
Compare
ljharb
force-pushed
the
feat/improve-messages
branch
from
bd2637f to
bfb0e9e
Compare
ljharb
approved these changes
Dec 24, 2024
ljharb
changed the title
label-has-associated-control: improve error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the error messages of the label-has-associate-control rule so that each assert type gets an error message with verbiage specific to the assertion.
I wanted to land this before adding support for matching a label's htmlFor attribute with the associated control's id