Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove array-includes #964

Closed
wants to merge 1 commit into from

Conversation

dulmandakh
Copy link

@dulmandakh dulmandakh commented Nov 10, 2023

let's remove support for very old version of Node.js, and array-includes polyfill. And after a while, let's release a new major version.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #964 (c252de0) into main (1635dcc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         105      105           
  Lines        1628     1628           
  Branches      578      578           
=======================================
  Hits         1612     1612           
  Misses         16       16           
Files Coverage Δ
src/rules/control-has-associated-label.js 100.00% <100.00%> (ø)
src/rules/interactive-supports-focus.js 97.05% <100.00%> (ø)
...s/no-interactive-element-to-noninteractive-role.js 100.00% <100.00%> (ø)
...rc/rules/no-noninteractive-element-interactions.js 100.00% <100.00%> (ø)
...s/no-noninteractive-element-to-interactive-role.js 100.00% <100.00%> (ø)
src/rules/no-noninteractive-tabindex.js 97.36% <100.00%> (ø)
src/rules/no-redundant-roles.js 100.00% <100.00%> (ø)
src/util/isInteractiveElement.js 100.00% <100.00%> (ø)
src/util/isInteractiveRole.js 100.00% <100.00%> (ø)
src/util/isNonInteractiveElement.js 100.00% <100.00%> (ø)
... and 2 more

@ljharb ljharb added the wontfix label Nov 10, 2023
@ljharb ljharb marked this pull request as draft November 10, 2023 17:20
@ljharb
Copy link
Member

ljharb commented Nov 10, 2023

No, let's not, thanks. Same discussion as in the other repo. This would be a breaking change immediately, and removing a polyfill isn't a valuable enough change to be worth the insanely high cost of a semver-major.

@ljharb ljharb closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants