Fix lint check, fix many clang-tidy warnings. #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtv
changed the title
jtv
changed the title
jtv
changed the title
Fixed the lint script, and ran it with the full C++ Core Guidelines. I'm not keeping that check, because it produces too many false positives or problems I just can't work around. But I found some things I could improve.
The only time this class needs to know the difference is during construction. Feels good to drop a data member. _Kudos_ to `clang-tidy` for spotting this.
Also, use `std::isspace()`, not the C version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling a lot of
clang-tidychecks. There are some things I'm not going to fix for various reasons — some imposed by libpq, some false positives, some conflicting with the design, and one requiring a third-party library.