Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Move data downloading/handling to junifer-data package. #363

Merged
merged 13 commits into from
Feb 13, 2025

Conversation

synchon
Copy link
Member

@synchon synchon commented Jan 21, 2025

Are you requiring a new dataset or marker?

  • I understand this is not a marker or dataset request

Which feature do you want to include?

Currently, Junifer is handling the data, downloading from various sources. Ideally, this should be centralized and versiones.

How do you imagine this integrated in junifer?

  1. Junifer uses the junifer-data API.
  2. junifer-data keeps a datalad dataset with all data objects, including externals. Each commit to this datasets has a tag.
  3. junifer knows exactly which is the tag that we are dealing with, so each junifer version will always work with the same data files.
  4. We have a command download or similar that makes junifer download all (or the requested) files to be used later on with the run command.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

@fraimondo fraimondo added enhancement New feature or request triage New issues waiting to be reviewed labels Sep 24, 2024
@fraimondo fraimondo added this to the 0.0.6 (alpha 5) milestone Sep 24, 2024
@fraimondo fraimondo removed the triage New issues waiting to be reviewed label Sep 24, 2024
@fraimondo fraimondo changed the title [ENH]: Move data downlading/handling to junifer-data package. [ENH]: Move data downloading/handling to junifer-data package. Sep 24, 2024
@fraimondo fraimondo mentioned this pull request Sep 24, 2024
1 task
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (b39d56b) to head (700aa5f).
Report is 14 commits behind head on main.

❌ Your project status has failed because the head coverage (85.67%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   85.58%   85.67%   +0.09%     
==========================================
  Files         133      133              
  Lines        5652     5633      -19     
  Branches      958      954       -4     
==========================================
- Hits         4837     4826      -11     
+ Misses        624      618       -6     
+ Partials      191      189       -2     
Flag Coverage Δ
junifer 85.67% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/data/coordinates/_coordinates.py 79.71% <100.00%> (+0.29%) ⬆️
junifer/data/masks/_masks.py 68.57% <100.00%> (ø)
junifer/data/parcellations/_parcellations.py 92.12% <100.00%> (+0.17%) ⬆️
junifer/data/template_spaces.py 81.81% <100.00%> (+0.42%) ⬆️
junifer/data/utils.py 62.50% <100.00%> (-4.17%) ⬇️
junifer/typing/_typing.py 100.00% <100.00%> (ø)

@synchon synchon added parcellation Issues or pull requests related to parcellations (atlases) coordinate Issues or pull requests related to coordinates (ROIs) mask Issues or pull requests related to masks labels Jan 21, 2025
@synchon synchon force-pushed the refactor/junifer-data-api branch from 81ced3b to fae153d Compare January 24, 2025 16:29
@synchon
Copy link
Member

synchon commented Jan 24, 2025

  1. We have a command download or similar that makes junifer download all (or the requested) files to be used later on with the run command.

This is not yet implemented and would depend on junifer-data API. Will implement after the necessary API is available from junifer-data.

Copy link

github-actions bot commented Jan 24, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://juaml.github.io/junifer/pr-preview/pr-363/

Built to branch gh-pages at 2025-01-27 11:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@synchon synchon force-pushed the refactor/junifer-data-api branch 2 times, most recently from 3025086 to a6a65c4 Compare January 30, 2025 17:24
@synchon synchon requested a review from fraimondo January 30, 2025 17:25
@synchon
Copy link
Member

synchon commented Feb 10, 2025

  1. We have a command download or similar that makes junifer download all (or the requested) files to be used later on with the run command.

This is not yet implemented and would depend on junifer-data API. Will implement after the necessary API is available from junifer-data.

junifer-data-client v1.1.0 now has a download command to do this via CLI only.

@synchon synchon requested a review from fraimondo February 12, 2025 11:15
@fraimondo
Copy link
Contributor Author

CI is not green though

@synchon synchon force-pushed the refactor/junifer-data-api branch from ce1d4c2 to e4ad5e1 Compare February 13, 2025 09:03
@synchon
Copy link
Member

synchon commented Feb 13, 2025

CI is not green though

It's a new problem with gh-action where numpy is not getting built for the docs. Will take care of it after getting the important stuff in.

@synchon synchon merged commit 02e0b6f into main Feb 13, 2025
13 of 18 checks passed
@synchon synchon deleted the refactor/junifer-data-api branch February 13, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coordinate Issues or pull requests related to coordinates (ROIs) enhancement New feature or request mask Issues or pull requests related to masks parcellation Issues or pull requests related to parcellations (atlases)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants