-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Move data downloading/handling to junifer-data
package.
#363
Conversation
junifer-data
package.junifer-data
package.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.67%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 85.58% 85.67% +0.09%
==========================================
Files 133 133
Lines 5652 5633 -19
Branches 958 954 -4
==========================================
- Hits 4837 4826 -11
+ Misses 624 618 -6
+ Partials 191 189 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
81ced3b
to
fae153d
Compare
This is not yet implemented and would depend on |
|
3025086
to
a6a65c4
Compare
|
CI is not green though |
ce1d4c2
to
e4ad5e1
Compare
It's a new problem with gh-action where numpy is not getting built for the docs. Will take care of it after getting the important stuff in. |
Are you requiring a new dataset or marker?
Which feature do you want to include?
Currently, Junifer is handling the data, downloading from various sources. Ideally, this should be centralized and versiones.
How do you imagine this integrated in junifer?
junifer-data
API.junifer-data
keeps a datalad dataset with all data objects, including externals. Each commit to this datasets has a tag.junifer
knows exactly which is the tag that we are dealing with, so each junifer version will always work with the same data files.download
or similar that makes junifer download all (or the requested) files to be used later on with therun
command.Do you have a sample code that implements this outside of junifer?
No response
Anything else to say?
No response