Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]: Use junifer-data datalad dataset for fetching data #418

Merged
merged 22 commits into from
Feb 13, 2025
Merged

[ENH]: Use junifer-data datalad dataset for fetching data #418

merged 22 commits into from
Feb 13, 2025

Conversation

synchon
Copy link
Member

@synchon synchon commented Jan 8, 2025 •
edited
Loading

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR adapts junifer-data datalad dataset at https://github.com/juaml/junifer-data to provide data for junifer.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://juaml.github.io/junifer/pr-preview/pr-418/

Built to branch gh-pages at 2025-01-27 11:19 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@synchon synchon requested a review from fraimondo January 8, 2025 15:23
@synchon synchon added enhancement New feature or request parcellation Issues or pull requests related to parcellations (atlases) coordinate Issues or pull requests related to coordinates (ROIs) mask Issues or pull requests related to masks labels Jan 8, 2025
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 123 lines in your changes missing coverage. Please review.

Project coverage is 0.01%. Comparing base (5135251) to head (a8582b6).

Files with missing lines Patch % Lines
junifer/data/parcellations/_parcellations.py 0.00% 60 Missing ⚠️
junifer/data/utils.py 0.00% 34 Missing ⚠️
junifer/data/masks/_masks.py 0.00% 16 Missing ⚠️
junifer/data/coordinates/_coordinates.py 0.00% 11 Missing ⚠️
junifer/data/template_spaces.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##            main    #418    +/-   ##
======================================
  Coverage   0.01%   0.01%            
======================================
  Files        133     133            
  Lines       5795    5652   -143     
======================================
  Hits           1       1            
+ Misses      5794    5651   -143
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/data/template_spaces.py 0.00% <0.00%> (ø)
junifer/data/coordinates/_coordinates.py 0.00% <0.00%> (ø)
junifer/data/masks/_masks.py 0.00% <0.00%> (ø)
junifer/data/utils.py 0.00% <0.00%> (ø)
junifer/data/parcellations/_parcellations.py 0.00% <0.00%> (ø)

fraimondo
fraimondo requested changes Jan 10, 2025
View reviewed changes
@synchon
Copy link
Member Author

synchon commented Jan 24, 2025

Needs to go before #363

synchon added 17 commits February 10, 2025 14:35
@synchon
feat: add data.utils.check_dataset() to get or install junifer-data d…
310fcd3 
…ataset
@synchon
update: use data.utils.check_dataset() in get_xfm()
3dd8623
@synchon
chore: update junifer-data clone path
6b7e31a
@synchon
feat: add data.utils.fetch_file_via_datalad() to get files via datalad
429c962
@synchon
update: use data.utils.fetch_file_via_datalad() in get_xfm()
24a1797
@synchon
update: use junifer-data in CoordinatesRegistry.load()
9b087ec
@synchon
update: use junifer-data in MaskRegistry.load()
c2a367d
@synchon
fix: update init and registration logic for CoordinatesRegistry
d9a3717
@synchon
chore: update CoordinatesRegistry tests
feb0e13
@synchon
fix: update init and registration logic for MaskRegistry
5f37246
@synchon
chore: update MaskRegistry tests
a3f2971
@synchon
chore: lint
1344a81
@synchon
chore: update commentary for MaskRegistry
99e0e0d
@synchon
update: store Path instead of str for external entries in MaskRegistry
88b624b
@synchon
update: use junifer-data in ParcellationRegistry.load(); fix: update …
e5d6b00 
…init and registration logic for ParcellationRegistry
@synchon
chore: update ParcellationRegistry tests
a986bc9
@synchon
chore: remove unnecessary Path conversion in MaskRegistry
91b59d7
@synchon synchon merged commit b39d56b into main Feb 13, 2025
3 of 14 checks passed
@synchon synchon deleted the enh/junifer-data branch February 13, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fraimondo fraimondo fraimondo requested changes

Assignees
No one assigned
Labels
coordinate Issues or pull requests related to coordinates (ROIs) enhancement New feature or request mask Issues or pull requests related to masks parcellation Issues or pull requests related to parcellations (atlases)
Projects
None yet
Milestone
0.0.6 (alpha 5)
Development

Successfully merging this pull request may close these issues.
2 participants
@synchon @fraimondo