[ENH]: Add test for JuniferNiftiSpheresMasker against nilearn's version
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraimondo
added
enhancement
|
For the moment, let's fix 0.10.0 as the latest supported nilearn version. Onces 0.10.1 is released, let's add the tests and version-specific patches. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
fraimondo
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you requiring a new dataset or marker?
Which feature do you want to include?
We reimplemented (by copying) a
JuniferNiftiSpheresMaskerthat has the same functionality ofNiftiSpheresMaskerbut allows to change the aggregation function.The tests are also a copy of Nilearn's one.
If
agg_function = 'mean', then they should both behave equally. I would like to have a test so we can corroborate this. They should be numerically equal.How do you imagine this integrated in junifer?
One more test in
junifer.external.nilearn.testsDo you have a sample code that implements this outside of junifer?
No response
Anything else to say?
No response