Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SetHost & GetHost #1

Closed
wants to merge 2 commits into from
Closed

feat: SetHost & GetHost #1

wants to merge 2 commits into from

Conversation

GoldenSheep402
Copy link
Contributor

I'm not sure if it's appropriate to put setHost and getHost inside the user service. If it's not, could you please give me some advice? My experience is still quite limited. Thank you, bros.

@asjdf
Copy link
Member

asjdf commented Sep 17, 2023

非常抱歉刚刚看到这个pr,刚刚开一个pr上来,如果方便的话我们移步 #2

@asjdf asjdf self-requested a review September 17, 2023 15:30
@@ -9,10 +9,27 @@ enum UserStatus {
USER_STATUS_WAIT_EMAIL_CHECK = 3; // 等待验证邮箱
}

enum HostSyncMode {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实际上这个sync的动作应该只会存在“同步”这个情况

message User {
string id = 1;
string nick_name = 2; // 用户名
UserStatus status = 3; // 用户状态
string avatar = 4; // 头像链接
string email = 5; // 邮箱
}

message Host {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host的字段我看了下,差不多,但好像缺了一点,比如key之类的


message GetInfoRequest {
rpc SetNewHost(SetNewHostRequest) returns(SetNewHostResponse) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块考虑放到sync之类的包里叭?


// SetNewHost
message SetNewHostRequest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边sync的模式/流程是咋样的?

@GoldenSheep402 GoldenSheep402 deleted the GoldenSheep-dev branch September 22, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants