feat(encrypt): support encrypt when sync #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoldenSheep402
force-pushed
the
feat/encrypt
branch
from
deb04af to
91e50bf
Compare
asjdf
requested changes
Nov 6, 2023
asjdf
changed the title
asjdf
requested changes
Nov 6, 2023
proto/sync/v1/sync_service.proto
Outdated
| @@ -48,8 +60,11 @@ message SyncResponse { | |||
| repeated Identity identity_set = 14; | |||
| } | |||
|
|
|||
| // 如果是用于创建新的组，则提供master_key,用于加密rsa密钥 | |||
| message UpdateRequest { | |||
There was a problem hiding this comment.
建议请求名称打全，UpdateRequest的翻译结果是“更新请求”，单独看很难看出来是update啥
|
asjdf
requested changes
Nov 11, 2023
proto/sync/v1/sync_service.proto
Outdated
| @@ -48,8 +60,11 @@ message SyncResponse { | |||
| repeated Identity identity_set = 14; | |||
| } | |||
|
|
|||
| // 如果是用于创建新的组，则提供master_key,用于加密rsa密钥 | |||
| message UpdateRequest { | |||
|
来观测一下进度x |
asjdf
requested changes
Nov 15, 2023
proto/sync/v1/group.proto
Outdated
| string publicKey = 9; // 公钥,公钥存在服务器上，加密的私钥与相关用户关联存储 | ||
| } | ||
|
|
||
| message GroupKeyChain{ |
There was a problem hiding this comment.
sync的时候肯定还得鉴权，不能单靠key来管 另外key是在用户的keyWallet里头 而不是在群组下
There was a problem hiding this comment.
这个PubKey是用来加密具体组的密钥，不是个人的
There was a problem hiding this comment.
打算是用于加密组的组PubKey和组直接放一起 作为基本信息，PriKey直接存到用户KeyWallet下，鉴权的话涉及密钥操作就判断是否是管理和非管理的区别
|
________________________________
From: GoldenSheep ***@***.***>
Sent: Wednesday, November 22, 2023 10:44:08 AM
To: juanjiTech/termium-proto ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [juanjiTech/termium-proto] feat(encrypt): support encrypt when sync (PR #11)
加邀请，接受，删除 这三个功能的接口吧
—
Reply to this email directly, view it on GitHub<#11 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEOGQQVVF5YTNEQXQ3LSM33YFXJPRAVCNFSM6AAAAAA66K7BAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRSGUZDIOBXGQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
草 看到了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
创建新组的时候生成密钥链
获取加密的密钥是根据提供的gid获取
修改master_key时，将服务器上用户相关的密钥全部更新