feat: sync/group #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asjdf
reviewed
Sep 26, 2023
proto/sync/v1/group.proto
Outdated
| string name = 2; | ||
| string description = 3; | ||
| string avatar = 4; | ||
| google.protobuf.Timestamp created_at = 14; |
proto/sync/v1/group.proto
Outdated
| google.protobuf.Timestamp updated_at = 15; | ||
| google.protobuf.Timestamp deleted_at = 16; | ||
| string uid = 17; // 创建者 | ||
| bool is_personal = 18; // 是否是个人组 |
There was a problem hiding this comment.
这个字段是不是考虑一下有没有必要？就是说是否要区分group的类型？不区分的情况下能不能实现需求
There was a problem hiding this comment.
可以是可以实现需求，is_personal的目的是不让用户把私人空间分享出去
There was a problem hiding this comment.
感觉主要是涉及到定价策略。是不是直接根据用户的订阅等级禁用group分享一类的接口？
GoldenSheep402
commented
Sep 26, 2023
asjdf
requested changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateGroup & SyncGroup
UpdateGroup用于修改group信息
SyncGroup用于获取group信息