-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased version of #125 #128
Conversation
When the raw option is set, subrenderer for cells in tables use the full available width and ensure text within a cell is next to eachother in the rendered text. Raw mode additionally does not draw table boundaries. The implementation of this must switch the iteration order from first iterating over same lines of adjacent cells to first iterating over the cells and then over every line of that cell.
src/render/text_renderer.rs
Outdated
@@ -169,6 +169,18 @@ impl<T: Debug + Eq + PartialEq + Clone + Default> TaggedLine<T> { | |||
true | |||
} | |||
|
|||
/// Return true if the line is non-empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comment is backwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@sftse This looks good to me. Do you have any concerns about how it works now?
Do you mean the "vertical row" feature? (If columns don't fit next to each other, fall back to putting them on top of each other with "////" as a border to try to show they belong side by side) That's a good point, thinking about it. Maybe raw mode doesn't need much more than:
along with |
Ok, I've updated to use vertical rows instead of a separate loop over rows. |
I can't push to this branch, but this idea turned out great. I reverted even more of my previous changes, see #129 |
No description provided.