Error wrapping #183
Merged
Error wrapping #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch by CI, didn't mean to break semver. |
…pe as long as possible
|
Thanks! Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was taking a closer look at error handling, I noticed that some small changes can make it simpler to understand where errors are coming from.
The two most significant changes are to introduce a specific rendering error type that is only converted to the library-wide
Erroras late as possible and to move Ok-wrapping of closure return types as close to theconsidentifier as possible. This last change permits grepping for theconsidentifier and one can see at a glance whether the closure can error or not.